idlcomp: valgrind fixes

[polintos/scott/priv.git] / idlcomp / idlc.h

diff --git a/idlcomp/idlc.h b/idlcomp/idlc.h
index e030bbe52ba5dc355b0068c2f9bb5293c249c5e4..a4ca39ab0f7ebd7fa12faa4051006dc55d994843 100644 (file)
--- a/idlcomp/idlc.h
+++ b/idlcomp/idlc.h
@@ -447,6 +447,8 @@ typedef Ref<IDList> IDListRef;
 class NameSpace;
 class LangCallback;
 
+typedef Ref<NameSpace> NameSpaceRef;
+
 // This is incremented when a chain of symbols is traversed to reset
 // detection of already-visited symbols.  It is assumed that this
 // will not have to happen billions of times.
@@ -488,9 +490,6 @@ public:
        
        Symbol(const String *_name) : name(_name)
        {
-               if (_name)
-                       name->retain();
-
                init();
        }
 
@@ -585,8 +584,6 @@ struct InvalidArgument {
 struct UserError {
 };
 
-typedef Ref<NameSpace> NameSpaceRef;
-
 class NameSpace : public virtual Symbol {
 protected:
        // Filesystem path to the external symbol storage, or NULL
@@ -617,23 +614,15 @@ protected:
        list<NameSpaceRef> imports;
 
 public:
-       // This is set in the destructor, so the contents of the namespace
-       // don't try to remove themselves from the namespace when destructed
-       // due to the destruction of map.
-       int dying;
-       
        // This is a counter for generating unique names for anonymous
        // members of the namespace.
        int anon;
        
-       NameSpace() : dying(0), anon(0)
+       NameSpace() : anon(0)
        {
        }
        
-       virtual ~NameSpace()
-       {
-               dying = 1;
-       }
+       virtual ~NameSpace();
        
        // Return a description of the type of namespace, for
        // error messages.
@@ -704,13 +693,12 @@ public:
        // SymbolNotFound is thrown if sym is not in this namespace.
        virtual void del(Symbol *sym)
        {
-               fprintf(stderr, "Removing symbol %s\n",
-                       sym->get_fq_name()->flatten()->c_str());
-       
-               if (tbl.erase(sym->name) == 0)
+               if (sym->ns != this)
                        throw SymbolNotFound();
-               
+
                sym->ns = NULL;
+               int ret = tbl.erase(sym->name);
+               assert(ret != 0);
        }
 
 private:       
@@ -1280,7 +1268,7 @@ public:
 
 class Struct;
 typedef Ref<Struct> StructRef;
-extern Struct *System_VStruct;
+extern StructRef System_VStruct;
 
 // FIXME: typedefed superstructs
 class Struct : public NameSpace, public Type, public Def {
@@ -1651,7 +1639,7 @@ typedef Ref<Method> MethodRef;
 class Interface;
 typedef Ref<Interface> InterfaceRef;
 
-extern Interface *System_Object;
+extern InterfaceRef System_Object;
 
 // FIXME: typedefed superinterfaces
 class Interface : public NameSpace, public Type, public Def {